Add new interaction channel attribute #1621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure whether to get rid of I would get rid of them, but I would like more feedback :) |
| @@ -2542,7 +2542,7 @@ def deserialize_command_interaction( | |||
| guild_id=guild_id, | |||
| guild_locale=locales.Locale(payload["guild_locale"]) if "guild_locale" in payload else None, | |||
| locale=locales.Locale(payload["locale"]), | |||
| channel_id=snowflakes.Snowflake(payload["channel_id"]), | |||
| channel=self.deserialize_partial_channel(payload["channel"]), | |||
There was a problem hiding this comment.
the channel objects here include a lot more fields than just the partial channel's fields
e.g.
{
"type": 0,
"topic": null,
"theme_color": null,
"rate_limit_per_user": 0,
"position": 20,
"permissions": "140737488355327",
"parent_id": "561885448721399808",
"nsfw": false,
"name": "dwads",
"last_message_id": "1114922806820479057",
"id": "717586538925523004",
"icon_emoji": {
"name": "\ud83e\udd16",
"id": null
},
"guild_id": "561884984214814744",
"flags": 0,
"default_auto_archive_duration": 60
}{
"type": 1,
"last_message_id": "1096465893028003910",
"id": "463185043796262922",
"flags": 0
}There was a problem hiding this comment.
This was also mentioned in the PR which documented this field discord/discord-api-docs#6051 (comment), just another case of Discord having shit docs tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
noxand all the pipelines have passed.